build: small fixups for LLVM 21 support#2034
Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:mainfrom Oct 29, 2025
Merged
build: small fixups for LLVM 21 support#2034lgritz merged 1 commit intoAcademySoftwareFoundation:mainfrom
lgritz merged 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Alex Fuller <boberfly@gmail.com>
9fd699b to
9a3cfb0
Compare
lgritz
approved these changes
Oct 29, 2025
Collaborator
lgritz
left a comment
There was a problem hiding this comment.
LGTM. Thanks for catching this.
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 29, 2025
Signed-off-by: Alex Fuller <boberfly@gmail.com>
bisqottii
pushed a commit
to bisqottii/OpenShadingLanguage
that referenced
this pull request
Jan 24, 2026
Signed-off-by: Alex Fuller <boberfly@gmail.com> Signed-off-by: Alexandru Biscoveanu <alex.biscoveanu.gfx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I wanted to move onto LLVM 21 so I tried the new #2030 merge but I think it wasn't tested with Optix and there were a few
setTargetTriplecalls that needed to be tweaked as well.Tests
Just a basic build with Optix 9 and LLVM 21.1.2 works with this.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.